Skip to content

Feat: gRPC message size configurable for TS SDK#3881

Open
jishnundth wants to merge 4 commits into
hatchet-dev:mainfrom
jishnundth:jndth/ts-grpc-size
Open

Feat: gRPC message size configurable for TS SDK#3881
jishnundth wants to merge 4 commits into
hatchet-dev:mainfrom
jishnundth:jndth/ts-grpc-size

Conversation

@jishnundth
Copy link
Copy Markdown
Contributor

Description

Make gRPC message send and receive size configurable at the user level for TS SDK.

Type of change

  • New feature (non-breaking change which adds functionality)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

@jishnundth is attempting to deploy a commit to the Hatchet Team on Vercel.

A member of the Team first needs to authorize it.

@promptless-for-oss
Copy link
Copy Markdown

Promptless prepared a documentation update related to this change.

Triggered by PR #3881

Updated worker configuration documentation to include the new TypeScript SDK gRPC message size options (grpc_max_recv_message_length, grpc_max_send_message_length) and their corresponding environment variables, with programmatic configuration examples for both Python and TypeScript.

Review: Document gRPC message size configuration for TypeScript SDK

Comment thread sdks/typescript/CHANGELOG.md Outdated
@jishnundth jishnundth force-pushed the jndth/ts-grpc-size branch from ea30b23 to 6077616 Compare May 17, 2026 10:47
@BloggerBust
Copy link
Copy Markdown
Contributor

@jishnundth thanks for the PR. I locally validated this against a fresh Docker stack using Hatchet engine v0.83.37, and the change looks good overall.

One small thing I would like to improve before approval: the env parsing currently uses parseInt, so a malformed value like HATCHET_CLIENT_GRPC_MAX_RECV_MESSAGE_LENGTH=4mb would parse as 4 instead of being rejected. Could you update the parsing to reject malformed values and add a config-loader test covering that scenario?

@jishnundth jishnundth force-pushed the jndth/ts-grpc-size branch from 7e7fd5c to d6fd8e8 Compare May 19, 2026 16:12
@jishnundth
Copy link
Copy Markdown
Contributor Author

@jishnundth thanks for the PR. I locally validated this against a fresh Docker stack using Hatchet engine v0.83.37, and the change looks good overall.

One small thing I would like to improve before approval: the env parsing currently uses parseInt, so a malformed value like HATCHET_CLIENT_GRPC_MAX_RECV_MESSAGE_LENGTH=4mb would parse as 4 instead of being rejected. Could you update the parsing to reject malformed values and add a config-loader test covering that scenario?

Done!

@BloggerBust
Copy link
Copy Markdown
Contributor

Thank you, I re-evalidated locally and the parsing fix addresses my concern. I also see the TypeScript SDK changelog and version update is included. This looks ready to merge. @gregfurman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants